Conversation
and they even pass
Some day we can split the software math into its own crate and do quickcheck there, until then the test code must be fully no_std because otherwise the examples won't build (sadly, dev-dependencies applies to both tests and examples)
parasyte
reviewed
Dec 21, 2018
Contributor
parasyte
left a comment
parasyte
left a comment
There was a problem hiding this comment.
So far I just found some typos.
| Also, again signed values can be annoying, because if the value _just happens_ | ||
| to be `i32::MIN` then when you negate it you'll have... _still_ a negative | ||
| value. I'm not 100% on this, but I think the correct thing to do at that point | ||
| is to give `$t::MIN` as out output num value. |
Contributor
There was a problem hiding this comment.
Suggested change
| is to give `$t::MIN` as out output num value. | |
| is to give `$t::MIN` as the output num value. |
| value. I'm not 100% on this, but I think the correct thing to do at that point | ||
| is to give `$t::MIN` as out output num value. | ||
|
|
||
| Did you get all that? Good, because this is involves casting, we will need to |
Contributor
There was a problem hiding this comment.
Suggested change
| Did you get all that? Good, because this is involves casting, we will need to | |
| Did you get all that? Good, because this involves casting, we will need to |
Member
Author
|
It seems like I can't accept the suggestions directly since I already merged this PR, but I'll put it into my files and it'll show up in the next PR. |
Contributor
|
Yeah, I was a bit late hitting the submit button. There was a lot to read through. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.