Skip to content

Hello World is 100% Safe#38

Merged
Lokathor merged 13 commits intomasterfrom
lokathor
Dec 24, 2018
Merged

Hello World is 100% Safe#38
Lokathor merged 13 commits intomasterfrom
lokathor

Conversation

@Lokathor
Copy link
Member

No description provided.

@Lokathor Lokathor requested a review from Ravenslofty December 23, 2018 21:48
totally normal. If not, just remember to call `read_key_input` once per frame
and then use that `KeyInput` value across the whole frame.

### Detecting New Presses

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debouncing would be a good topic to talk about here. I'm assuming the hardware doesn't debounce for the software.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During an particular CPU cycle the buttons will be either on or off, but there's no more special processing than that.

@Lokathor Lokathor requested a review from dannyfritz December 24, 2018 20:10
Copy link

@dannyfritz dannyfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Lokathor Lokathor merged commit 9b7751f into master Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants