Add getter for known migrations to runner.#120
Merged
jxs merged 2 commits intorust-db:masterfrom Jul 14, 2020
Merged
Conversation
jxs
requested changes
Jul 13, 2020
refinery_core/src/runner.rs
Outdated
|
|
||
| /// set the target version up to which refinery should migrate, Latest migrates to the latest version available | ||
| /// Get the known migrations. | ||
| pub fn get_migrations(self) -> Vec<Migration> { |
Member
There was a problem hiding this comment.
we don't want to consume the Runner, should be &self
Contributor
Author
There was a problem hiding this comment.
And I'm guessing
pub fn get_migrations(&self) -> &Vec<Migration> {
&self.migrations
}
is better than
pub fn get_migrations(&self) -> Vec<Migration> {
self.migrations.clone()
}
(new to Rust :))
Member
There was a problem hiding this comment.
yeah, no need to clone, let the caller of the function decide if they want to call clone
jxs
reviewed
Jul 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117