Correctly handle escaped strings when parsing json strings. Fixes #30 & #31 #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasKoch
changed the title
Collaborator
Author
|
@eldruin Could we get some of these PRs merged now? I think all 6 are good to go before a new release? |
Member
|
@MathiasKoch Thanks for the summary. Will do. I just need to go through them in detail. |
eldruin
reviewed
Dec 10, 2020
Member
eldruin
left a comment
eldruin
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
Could you add an entry to the changelog before the merge?
Collaborator
Author
|
I will merge these and open a new PR with combined changelog entries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly handle escaped strings when parsing json strings.
Fixes #31
Fixes #30