-
Notifications
You must be signed in to change notification settings - Fork 68
Newtype, variants and unit #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ser:
* Added newtype serialization (as underlying value)
* Added newtype_variant serialization (as object)
* Added unit serialization (as null)
der:
* Added unit de
* Added newtype_struct
* Implement VariantAccess for non unit enums * Add newtype_variant & struct_variant deserialization * Basic tests for both * Remove Unreachable impl for SerializationStructVariant
Collaborator
Author
|
Hmm.. Not sure why the CI fails here? @eldruin ? |
Collaborator
Author
|
Ahh... How should that be handled? Go back to the manual one, and exclude it from clippy checks? |
Collaborator
Author
|
I think it might be a matter of raising MSRV? @eldruin would you be okay with me raising MSRV to 1.40.0? |
Member
|
I would be OK with raising the MSRV to 1.40.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ser/de for the following types:
unittypes, i.e()&struct Test;newtypestructs, ser/de'ing the underlying valuenewtype_variantformat, i.eVariant(u32)struct_variantformat, i.eVariant { x: u32, y: u16 }This is just #25 rebased on master