Newtype, variants and unit #25
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ser:
* Added newtype serialization (as underlying value)
* Added newtype_variant serialization (as object)
* Added unit serialization (as null)
der:
* Added unit de
* Added newtype_struct
* Implement VariantAccess for non unit enums * Add newtype_variant & struct_variant deserialization * Basic tests for both * Remove Unreachable impl for SerializationStructVariant
MabezDev
force-pushed
the
newtypes-variants-and-unit
branch
from
8ea4005 to
36cd0ce
Compare
Collaborator
|
+1 on this! Did a test yesterday, and it also fixes support for externally tagged enums (https://serde.rs/enum-representations.html) Good job! |
Collaborator
|
Ping @japaric |
eldruin
reviewed
Dec 10, 2020
|
|
||
| impl<'a, B> ser::SerializeStructVariant for SerializeStructVariant<'a, B> | ||
| where | ||
| B: ArrayLength<u8>, |
Member
|
@MathiasKoch how do you want to go about this one? |
Collaborator
|
Sure thing, give me 5 minutes. Will try to fix the CI clippy stuff at the same time. |
MathiasKoch
added a commit
to MathiasKoch/serde-json-core
that referenced
this pull request
Dec 11, 2020
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ser/de for the following types:
unittypes, i.e()&struct Test;newtypestructs, ser/de'ing the underlying valuenewtype_variantformat, i.eVariant(u32)struct_variantformat, i.eVariant { x: u32, y: u16 }