Fixed command bytes #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed first bytes for "PreChargePeriod" and "VcomhDeselect" to be what they should be in the datasheet (0xD9 and 0xDB, respectively). This fix got the driver working properly for my hardware (raspberry pi zero w + WaveShare SH1106 HAT). Before this fix, the display would behave differently in based on what seemed to be background cosmic radiation; sometimes it would work perfectly, sometimes it would go dark after a few seconds of displaying something.
jamwaffles
approved these changes
Dec 28, 2020
Collaborator
jamwaffles
left a comment
jamwaffles
left a comment
There was a problem hiding this comment.
Thanks for the fix! I don't have hardware on hand to test with right now, so I'll trust your judgement 😁
jamwaffles
added a commit
that referenced
this pull request
Dec 28, 2020
Collaborator
|
This has been released in 0.3.4. Please let me know if you run into any issues. |
Contributor
Author
|
I can verify that 0.3.4 works with my hardware. Thanks for the prompt response! |
Collaborator
|
Excellent 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed first bytes for
Command::PreChargePeriodandCommand::VcomhDeselectto be what they should be in the datasheet (0xD9and0xDB, respectively).This fix got the driver working properly for my hardware setup (Raspberry Pi Zero W + WaveShare SH1106 HAT).
Before this fix, the display would behave differently in based on what seemed to be background cosmic radiation; sometimes it would work perfectly, sometimes it would go dark after a few seconds of displaying something.
This relates to issue #7.