Display rotation #17
Merged
Display rotation #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealprof
reviewed
Mar 28, 2018
examples/rotation_i2c.rs
Outdated
| let mut disp = Builder::new() | ||
| .with_rotation(DisplayRotation::Rotate90) | ||
| .connect_i2c(i2c); | ||
| disp.init(); |
Collaborator
There was a problem hiding this comment.
I smell new warnings here. ;)
We get 180 degree (vertical flip) rotation for free by twiddling some options. 90 and 270 degree rotations will need some processing in `set_pixel()` but that's no biggie.
Takes rotation into account. Useful for dynamically placing stuff on the display. You can have some code that will work on both a 128x32 and 128x64 display, for example.
This change means that the wirse come out the top of a CRIUS display by default, mimicking the behaviour currently in master.
therealprof
previously approved these changes
Mar 28, 2018
Collaborator
therealprof
left a comment
therealprof
left a comment
There was a problem hiding this comment.
It looks okay to me. The example will cause new warnings due to ignored result and I think we should think about making some features (like rotation) also available after display initialisation.
Collaborator
Author
|
Thanks for reviewing. Fixed the example warnings and added a |
therealprof
approved these changes
Mar 28, 2018
Collaborator
Author
|
Boss! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 0, 90, 180 and 270 degree rotations to the display. Usable like so:
Also adds the
get_dimensions()method so consumers of this driver can position stuff relative to the display size.