Fix BufferedGraphicsMode::clear() so that it fills all pixels
#201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `clear()` fills the buffer with `0x01` bytes, which represent 7 dark pixels and 1 bright pixel. We want all pixels bright.
jamwaffles
approved these changes
Oct 27, 2023
Collaborator
jamwaffles
left a comment
jamwaffles
left a comment
There was a problem hiding this comment.
Well spotted. Thanks!
Collaborator
|
This is released in 0.8.4. |
Contributor
Author
|
Thanks, that was very fast! |
zyla
added a commit
to jborkowski/esp-jokes-rs
that referenced
this pull request
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for helping out with SSD1306 development! Please:
masterif you're not already up to dateCHANGELOG.mdentry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)rustfmton the project withcargo fmt --all- CI will not pass without this stepPR description
Currently
clear()fills the buffer with0x01bytes, which represent7 dark pixels and 1 bright pixel. We want all pixels bright. This PR fixes it by filling buffer with 0xff.