Skip to content
This repository was archived by the owner on Dec 2, 2020. It is now read-only.

Conversation

@nickray
Copy link
Contributor

@nickray nickray commented May 18, 2020

I must not be the only one who indulges in semihosting for quick print-debugging and then has a trail of intermediate mess...

With this new feature, one can easily patch out all these calls in the application (by additivity of cargo features), and get a binary that runs without debugger attached.

@nickray nickray requested a review from a team as a code owner May 18, 2020 19:39
@rust-highfive
Copy link

r? @korken89

(rust_highfive has picked a reviewer for you, use r? to override)

@nickray
Copy link
Contributor Author

nickray commented May 20, 2020

ping @korken89?

@adamgreig
Copy link
Member

I'm inclined to merge because I have often wanted exactly this feature and it would be useful. My only reservation is around negative features being generally considered unwise since any crate in the dependency tree could enable them. However, I don't think that's really an issue in this case: only the end user application would be likely to enable this feature anyway.

If no one else from @rust-embedded/cortex-m weighs in with an opinion soon I'll go ahead and merge.

@korken89
Copy link
Contributor

I have the same reservation, while I'd like it it would not work with the additive way features are speed to work.

But then again, this is a user facing crate so it will most likely not be an issue.

Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the practicality argument is compelling, let's merge this.

bors merge

@bors
Copy link
Contributor

bors bot commented May 25, 2020

Build succeeded:

@bors bors bot merged commit 442fb88 into rust-embedded:master May 25, 2020
@nickray nickray deleted the no-semihosting branch May 25, 2020 14:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants