Fix possible use after free in clear functions#647
Open
sgued wants to merge 1 commit intorust-embedded:mainfrom
Open
Fix possible use after free in clear functions#647sgued wants to merge 1 commit intorust-embedded:mainfrom
clear functions#647sgued wants to merge 1 commit intorust-embedded:mainfrom
Conversation
Contributor
|
@sgued Thanks so much for fixing this! I hope you don't mind me taking the liberty to improve on the description here, mainly adding |
zeenix
previously approved these changes
Feb 15, 2026
src/deque.rs
Outdated
| } | ||
| let this = Guard(self); | ||
| // SAFETY: Guard will be dropped and lead to a consistent empty state even in the case of a | ||
| // panic leading to unwinding during the dropping on an item |
Member
There was a problem hiding this comment.
Suggested change
| // panic leading to unwinding during the dropping on an item | |
| // panic leading to unwinding during the dropping of an item. |
Contributor
Author
There was a problem hiding this comment.
Good catch. Fixed it.
reitermarkus
previously approved these changes
Feb 15, 2026
sgued
force-pushed
the
646-clear-use-after-free
branch
from
8d03f31 to
3630d6e
Compare
The `drop` test of `deque` is renamed to `test_drop` to avoid name conflicts with the `std::mem::drop` function. Fix rust-embedded#646
sgued
force-pushed
the
646-clear-use-after-free
branch
from
3630d6e to
e458255
Compare
Contributor
Author
|
I fixed the typo and rephrased the commit message to match the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, the
droptest ofdequeis renamed totest_dropto avoid conflicts with thedropfunction.Fixes #646.