Skip to content

Adding meta theme-colour for nicer UI 🎨#31

Merged
bors[bot] merged 1 commit into
rust-embedded:masterfrom
sanjaiyan-dev:sanjaiyan-meta-theme-colour
Feb 15, 2023
Merged

Adding meta theme-colour for nicer UI 🎨#31
bors[bot] merged 1 commit into
rust-embedded:masterfrom
sanjaiyan-dev:sanjaiyan-meta-theme-colour

Conversation

@sanjaiyan-dev
Copy link
Copy Markdown
Contributor

@sanjaiyan-dev sanjaiyan-dev commented Feb 10, 2023

Adding <meta name="theme-color" /> we can customise the colour of the app bar. For more info please click here.

I have added #2f3360 as a theme colour :)

Extremely sorry if I made any mistakes :(

@sanjaiyan-dev sanjaiyan-dev requested a review from a team as a code owner February 10, 2023 18:53
Copy link
Copy Markdown
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how it looks like, thank you!
bors r+

bors Bot added a commit that referenced this pull request Feb 13, 2023
31: Adding meta theme-colour for nicer UI 🎨 r=eldruin a=sanjaiyan-dev

Adding `<meta name="theme-color" />` we can customise the colour of the app bar. For more info please [click here](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name/theme-color).

I have added `#2f3360` as a theme colour  :)

_Extremely sorry if I made any mistakes :(_

Co-authored-by: Sanjaiyan Parthipan <parthipankalayini@gmail.com>
@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Feb 13, 2023

Build failed:

  • build

@adamgreig
Copy link
Copy Markdown
Member

The CI failure looks unrelated, seems we need some maintenance on the showcase code itself for new versions of chrono.

bors Bot added a commit that referenced this pull request Feb 15, 2023
32: Update dependencies and adapt to them r=adamgreig a=eldruin

With this we can merge #31 

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Copy link
Copy Markdown
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try again, thank you!
bors r+

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Feb 15, 2023

Build succeeded:

  • build

@bors bors Bot merged commit ee5ddf5 into rust-embedded:master Feb 15, 2023
@sanjaiyan-dev sanjaiyan-dev deleted the sanjaiyan-meta-theme-colour branch January 27, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants