Fix escape char

[Shriyans406]

This PR ensures that characters like &, <, and > are escaped or avoided in SVD descriptions so that they don't break generated Rust docs

[burrbull]

svd string can contain valid html tags. How do you propose to process such cases?

[Shriyans406]

Thank you for the feedback! Escaping of < and > would break HTML formatting in the SVD. I've updated the implementation to be more selective, it now uses a regex to identify and preserve HTML tags (like <b>) and entities (like &amp;), while still escaping characters (like & and < that aren't part of a tag) to prevent them from being misinterpreted. I've also added unit tests covering these cases. Is it fine?

…

On Sat, Apr 25, 2026 at 5:42 PM Zgarbul Andrey ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/util.rs <#957 (comment)> : > @@ -179,11 +179,24 @@ pub fn escape_brackets(s: &str) -> String { /// Escape basic html tags and brackets pub fn escape_special_chars(s: &str) -> Cow<'_, str> { - if s.contains('[') { - escape_brackets(s).into() - } else { - s.into() + if !s.contains('[') && !s.contains('&') && !s.contains('<') && !s.contains('>'){ + return s.into(); + } + let mut escaped = s.to_string(); + if escaped.contains('&') { + escaped = escaped.replace('&', "&amp;"); + } + if escaped.contains('<') { + escaped = escaped.replace('<', "&lt;"); svd string can contain valid html tags. How do you propose to process such cases? — Reply to this email directly, view it on GitHub <#957 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BMTFX7WEFIQ7BN3DJBSO7F34XSTRJAVCNFSM6AAAAACYBIWM5GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DCNZVGUYTMNJWGM> . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/BMTFX7RMY2FRGAQQ24KR5TT4XSTRJA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMJXGU2TCNRVGYZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android <https://github.com/notifications/mobile/android/BMTFX7V5WUSVYUXUD5WCTMT4XSTRJA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMJXGU2TCNRVGYZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today! You are receiving this because you authored the thread.Message ID: ***@***.***>

[burrbull]

I don't see any changes in this PR.

[Shriyans406]

I think I made a mistake, so please check it sir. Regards

…

On Mon, Apr 27, 2026 at 9:55 AM Zgarbul Andrey ***@***.***> wrote: *burrbull* left a comment (rust-embedded/svd2rust#957) <#957 (comment)> I don't see any changes in this PR. — Reply to this email directly, view it on GitHub <#957 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BMTFX7RY6JKCB2MZLC7YGRL4X3ONFAVCNFSM6AAAAACYBIWM5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGMRUGA4TIMRQGU> . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/BMTFX7SHMZ5OCFBWONZJ6TD4X3ONFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMZSGQYDSNBSGA22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android <https://github.com/notifications/mobile/android/BMTFX7R4IBU3YJI7AT2PAGD4X3ONFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMZSGQYDSNBSGA22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today! You are receiving this because you authored the thread.Message ID: ***@***.***>