Skip to content

Add methods to set/remove delegations to StackState #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sorpaas merged 8 commits into from
Aug 12, 2025
Merged

Add methods to set/remove delegations to StackState #367

sorpaas merged 8 commits into from
Aug 12, 2025

Conversation

@manuelmauro
Copy link
Contributor

@manuelmauro manuelmauro commented Aug 11, 2025

Description

Adds set_delegation() and remove_delegation() methods to StackState trait for explicit delegation management instead of using generic set_code().

  • Adding a Delegation struct in a new core/src/delegation.rs module
  • Introducing set_delegation() and remove_delegation() methods to StackState

@manuelmauro manuelmauro changed the base branch from master to v0.x August 11, 2025 10:46
@manuelmauro manuelmauro marked this pull request as ready for review August 11, 2025 13:48
@manuelmauro manuelmauro mentioned this pull request Aug 11, 2025
Merged
RomarQ
RomarQ reviewed Aug 11, 2025
View reviewed changes
RomarQ
RomarQ approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@RomarQ RomarQ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few remarks, LGTM

@manuelmauro manuelmauro mentioned this pull request Aug 11, 2025
Merged
@RomarQ
Copy link
Contributor

RomarQ commented Aug 12, 2025

@sorpaas can this be merged?

@sorpaas sorpaas merged commit e3f0e92 into rust-ethereum:v0.x Aug 12, 2025
2 checks passed
@RomarQ RomarQ deleted the manuel/add-method-to-remove-delegations branch August 12, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sorpaas sorpaas sorpaas approved these changes

+1 more reviewer

@RomarQ RomarQ RomarQ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manuelmauro @RomarQ @sorpaas