fix: Prefer exact prefix/suffix matches when trimming replacements #345
+67
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
annotate-snippetscurrently tries to minify replacements by comparing the replacement to the original and "removing" any common prefix, then checks if the original's remainingcharmatch the end of the replacement. This works for most simple cases, but can produce odd results when the end of the replacement matches all of the original, and the replacement also shares some matching prefix with the original. This PR tries to address that edge case by first trying to strip all of the original from the replacement's prefix or suffix and returning the stripped string if it can.Code Example
Before:
After:
Written
original:
syncreplacement:
std::syncbefore:
td::safter:
std::Original
rust-lang/rustissueCloses #343