Skip to content

Remove unneeded wrap in reapproval comment message #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kobzol merged 1 commit into from
Nov 17, 2025
Merged

Remove unneeded wrap in reapproval comment message #461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions src/bors/handlers/pr_events.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,8 +312,7 @@ async fn notify_of_pushed_pr(
cancel_message: Option<String>,
) -> anyhow::Result<()> {
let mut comment = format!(
r#":warning: A new commit `{head_sha}` was pushed to the branch, the
PR will need to be re-approved."#
r#":warning: A new commit `{head_sha}` was pushed to the branch, the PR will need to be re-approved."#
);

if let Some(message) = cancel_message {
Expand Down Expand Up @@ -401,10 +400,7 @@ mod tests {

insta::assert_snapshot!(
tester.get_next_comment_text(()).await?,
@r"
:warning: A new commit `pr-1-commit-1` was pushed to the branch, the
PR will need to be re-approved.
"
@":warning: A new commit `pr-1-commit-1` was pushed to the branch, the PR will need to be re-approved."
);
tester.get_pr_copy(()).await.expect_unapproved();
Ok(())
Expand Down Expand Up @@ -714,13 +710,12 @@ mod tests {
.await?;
tester.push_to_pr(()).await?;
insta::assert_snapshot!(tester.get_next_comment_text(()).await?, @r"
:warning: A new commit `pr-1-commit-1` was pushed to the branch, the
PR will need to be re-approved.
:warning: A new commit `pr-1-commit-1` was pushed to the branch, the PR will need to be re-approved.

Auto build cancelled due to push. Cancelled workflows:
Auto build cancelled due to push. Cancelled workflows:

- https://github.com/rust-lang/borstest/actions/runs/123
");
- https://github.com/rust-lang/borstest/actions/runs/123
");
Ok(())
})
.await;
Expand All @@ -742,11 +737,10 @@ mod tests {
tester.workflow_start(tester.auto_branch().await).await?;
tester.push_to_pr(()).await?;
insta::assert_snapshot!(tester.get_next_comment_text(()).await?, @r"
:warning: A new commit `pr-1-commit-1` was pushed to the branch, the
PR will need to be re-approved.
:warning: A new commit `pr-1-commit-1` was pushed to the branch, the PR will need to be re-approved.

Auto build cancelled due to push. It was not possible to cancel some workflows.
");
Auto build cancelled due to push. It was not possible to cancel some workflows.
");
Ok(())
})
.await;
Expand Down