fix(layout): Put examples in their unit dir in new layout #16335
+51
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, pre-uplifted examples were being written to
`{build-dir}/{profile}/examples/{name}-{hash}`.
Now they are being written to
`{build-dir}/{profile}/build/{pkgname}/{hash}/{name}-{hash}`.
This does not affect uplifted examples (they lack the `-{hash}`).
Pre-build-dir, these were placed in a "public" location but I don't see
a reason for that to be the case (otherwise, we'd need to switch them to
`{target-dir}/{profile}/examples/{name}-{hash}`).
In that case, I don't see a reason to treat examples as any different
than any other artifact and going in their unique build init directory.
Fixes rust-lang#16302
rustbot
added
A-layout
Collaborator
Contributor
Author
|
CC @ranger-ross |
epage
commented
Dec 3, 2025
Comment on lines
225
to
226
| } else if unit.artifact.is_true() { | ||
| self.artifact_dir(unit) |
Contributor
Author
There was a problem hiding this comment.
I'm assuming we should eventually revisit this design as well so that artifact-deps doesn't affect the atomic nature of build units to allow for #5931.
epage
force-pushed
the
layout-new
branch
2 times, most recently
from
e99f374 to
298db39
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
|
Thanks! This makes sense to me. |
ranger-ross
approved these changes
Dec 4, 2025
weihanglo
approved these changes
Dec 4, 2025
rustbot
removed
the
S-waiting-on-review
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Dec 5, 2025
Update cargo submodule 9 commits in bd979347d814dfe03bba124165dbce9554d0b4d8..2c283a9a5c5968eeb9a8f12313f04feb1ff8dfac 2025-12-02 16:03:50 +0000 to 2025-12-04 16:47:28 +0000 - fix(publish): Move `.crate` out of final artifact location (rust-lang/cargo#15915) - Remove legacy tmpdir support (rust-lang/cargo#16342) - Run clippy CI on more targets (rust-lang/cargo#16340) - feat: support for rustdoc mergeable cross-crate info (rust-lang/cargo#16309) - fix(timings): unlocked -> unblocked (rust-lang/cargo#16337) - fix(layout): Put examples in their unit dir in new layout (rust-lang/cargo#16335) - fix(frontmatter): Restrict code fence length (rust-lang/cargo#16334) - Update resolver.md: fix compile errors in pseudocode (rust-lang/cargo#16333) - fix(fingerprint): clean doc dirs for only requested targets (rust-lang/cargo#16331) This is best being merged before beta cutoff because rust-lang/cargo#16337 is a nightly regression.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 5, 2025
Update cargo submodule 9 commits in bd979347d814dfe03bba124165dbce9554d0b4d8..2c283a9a5c5968eeb9a8f12313f04feb1ff8dfac 2025-12-02 16:03:50 +0000 to 2025-12-04 16:47:28 +0000 - fix(publish): Move `.crate` out of final artifact location (rust-lang/cargo#15915) - Remove legacy tmpdir support (rust-lang/cargo#16342) - Run clippy CI on more targets (rust-lang/cargo#16340) - feat: support for rustdoc mergeable cross-crate info (rust-lang/cargo#16309) - fix(timings): unlocked -> unblocked (rust-lang/cargo#16337) - fix(layout): Put examples in their unit dir in new layout (rust-lang/cargo#16335) - fix(frontmatter): Restrict code fence length (rust-lang/cargo#16334) - Update resolver.md: fix compile errors in pseudocode (rust-lang/cargo#16333) - fix(fingerprint): clean doc dirs for only requested targets (rust-lang/cargo#16331) This is best being merged before beta cutoff because rust-lang/cargo#16337 is a nightly regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Before, pre-uplifted examples were being written to
{build-dir}/{profile}/examples/{name}-{hash}.Now they are being written to
{build-dir}/{profile}/build/{pkgname}/{hash}/{name}-{hash}.This does not affect uplifted examples (they lack the
-{hash}).Pre-build-dir, these were placed in a "public" location but I don't see a reason for that to be the case (otherwise, we'd need to switch them to
{target-dir}/{profile}/examples/{name}-{hash}).In that case, I don't see a reason to treat examples as any different than any other artifact and going in their unique build init directory.
Fixes #16302
How to test and review this PR?