Skip to content

Conversation

@weihanglo
Copy link
Member

9 commits in bd979347d814dfe03bba124165dbce9554d0b4d8..2c283a9a5c5968eeb9a8f12313f04feb1ff8dfac
2025-12-02 16:03:50 +0000 to 2025-12-04 16:47:28 +0000

This is best being merged before beta cutoff because rust-lang/cargo#16337 is a nightly regression.

@weihanglo weihanglo self-assigned this Dec 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 4, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 4, 2025

⚠️ Warning ⚠️

@weihanglo
Copy link
Member Author

This is best being merged before beta cutoff because rust-lang/cargo#16337 is a nightly regression.

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Dec 4, 2025

📌 Commit d898b56 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2025
@bors
Copy link
Collaborator

bors commented Dec 5, 2025

⌛ Testing commit d898b56 with merge 864339a...

@bors
Copy link
Collaborator

bors commented Dec 5, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 864339a to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 5, 2025
@bors bors merged commit 864339a into rust-lang:main Dec 5, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Dec 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3e2dbcd (parent) -> 864339a (this PR)

Test differences

Show 12 test diffs

Stage 2

  • doc::mergeable_info_additive: [missing] -> ignore (rustdoc mergeable crate info is unstable) (J0)
  • doc::mergeable_info_dep_collision: [missing] -> ignore (rustdoc mergeable crate info is unstable) (J0)
  • doc::mergeable_info_gated: [missing] -> ignore (rustdoc mergeable crate info is unstable) (J0)
  • doc::mergeable_info_multi_targets: [missing] -> ignore (rustdoc mergeable crate info is unstable) (J0)
  • doc::mergeable_info_no_deps: [missing] -> ignore (rustdoc mergeable crate info is unstable) (J0)
  • doc::mergeable_info_rebuild_detection: [missing] -> ignore (rustdoc mergeable crate info is unstable) (J0)
  • doc::mergeable_info_rebuild_with_depinfo: [missing] -> ignore (rustdoc mergeable crate info is unstable; rustdoc --emit is unstable) (J0)
  • doc::mergeable_info_with_deps: [missing] -> ignore (rustdoc mergeable crate info is unstable) (J0)
  • doc::mergeable_info_workspace: [missing] -> ignore (rustdoc mergeable crate info is unstable) (J0)
  • script::rustc::fence_too_many_dashes: [missing] -> ignore (-Zscript is unstable) (J0)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 864339abf952f07098dd82610256338520167d4a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 3323.5s -> 4285.3s (+28.9%)
  2. aarch64-apple: 11458.6s -> 8798.0s (-23.2%)
  3. tidy: 151.3s -> 169.7s (+12.2%)
  4. x86_64-gnu-llvm-20-1: 3597.1s -> 3159.9s (-12.2%)
  5. aarch64-gnu-llvm-20-2: 2439.0s -> 2208.5s (-9.4%)
  6. x86_64-rust-for-linux: 3029.4s -> 2791.6s (-7.8%)
  7. aarch64-gnu: 6572.3s -> 7085.3s (+7.8%)
  8. x86_64-gnu-nopt: 7317.3s -> 6747.9s (-7.8%)
  9. i686-gnu-2: 5928.6s -> 5472.2s (-7.7%)
  10. dist-various-1: 3975.4s -> 3685.6s (-7.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (864339a): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 2.9%, secondary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.9% [1.9%, 3.9%] 2
Regressions ❌
(secondary)
2.2% [2.1%, 2.3%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.9% [1.9%, 3.9%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.045s -> 472.4s (0.50%)
Artifact size: 386.80 MiB -> 386.85 MiB (0.02%)

@weihanglo weihanglo deleted the update-cargo branch December 5, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants