test(build): Make it easier to review build.warnings behavior#16788
Merged
0xPoe merged 5 commits intorust-lang:masterfrom Mar 25, 2026
Merged
test(build): Make it easier to review build.warnings behavior#167880xPoe merged 5 commits intorust-lang:masterfrom
build.warnings behavior#167880xPoe merged 5 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
arlosi
reviewed
Mar 25, 2026
| [RUNNING] [..] | ||
| [WARNING] unused variable: `x` | ||
| ... | ||
| [WARNING] `has_warning` (lib) generated 1 warning |
Contributor
There was a problem hiding this comment.
Why does emitting a warning with warnings=deny not cause a build failure?
From our docs:
deny: if warnings are emitted, an error will be raised at the end of the operation and the process will exit with a failure exit code.
rustbot
removed
the
S-waiting-on-review
rust-bors bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Mar 28, 2026
Update cargo submodule 10 commits in e84cb639edfea2c42efd563b72a9be0cc5de6523..ddb37b06aba4dcf791fde56dd9fcf73ae7d05f7f 2026-03-21 01:27:07 +0000 to 2026-03-27 15:01:07 +0000 - fix(resolver): Better match rustc in error styling (rust-lang/cargo#16795) - missing -Zjson-target-spec error: mention that this is a cargo flag (rust-lang/cargo#16793) - Update changelog for 1.94.1 (rust-lang/cargo#16789) - test(build): Make it easier to review `build.warnings` behavior (rust-lang/cargo#16788) - test(build): Cover more behavior of `build.warnings` (rust-lang/cargo#16785) - chore(deps): bump curl-sys from 0.4.83 to 0.4.86 (rust-lang/cargo#16786) - Warn when installing with a non-default toolchain (rust-lang/cargo#16131) - feat(cli): Add support for completing `--config` argument values with `native-completions` (rust-lang/cargo#16249) - feat(cli): complete `--config` and `--color` before command (rust-lang/cargo#16780) - chore(deps): bump rustls-webpki from 0.103.9 to 0.103.10 (rust-lang/cargo#16778) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This is more test changes to help with preparing for stabilization
How to test and review this PR?