fix: Update `bash` and `zsh` Autocompletion Documents to add `-m` by bushrat011899 · Pull Request #16888 · rust-lang/cargo

bushrat011899 · 2026-04-15T01:29:35Z

What does this PR try to resolve?

Act on this request in Add -m shorthand for --manifest-path #16858
-m is short for --manifest-path, and must be added in places where --manifest-path could be accepted.

How to test and review this PR?

Use zsh, bash, or any other shell where Cargo provides autocomplete support, and ensure -m has identical behaviour to --manifest-path

Notes

I've never worked on these autocomplete documents before, so I'm assuming the modifications I've made are correct based on existing instances of shorthand (e.g., -F)
~~Creating as a draft until Add -m shorthand for --manifest-path #16858 is merged (which should be very soon).~~
No AI tooling of any kind was used during the creation of this PR.

rustbot · 2026-04-15T02:17:12Z

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @ehuss, @epage, @weihanglo
@ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
Random selection from ehuss, epage, weihanglo

bushrat011899 · 2026-04-15T02:18:06Z

r? @weihanglo

weihanglo · 2026-04-15T02:39:54Z

    triple='--target=[specify target triple]:target triple:_cargo_target_triple'
    target='--target-dir=[specify directory for all generated artifacts]:directory:_directories'
-    manifest='--manifest-path=[specify path to manifest]:path:_directories'
+    manifest='(-m --manifest-path)=[specify path to manifest]:path:_directories'


This should be something like

Suggested change

manifest='(-m --manifest-path)=[specify path to manifest]:path:_directories'

manifest=(

'(-m --manifest-path)'{-m+,--manifest-path=}'[specify path to manifest]:path:_directories'

)

similar to jobs

View changes since the review

you can test it with

zsh -f fpath=(src/etc $fpath) autoload -Uz compinit && compinit cargo build -m<TAB>

Tried testing it but I was struggling to get even existing completions working (I'm on a Windows machine and testing through WSL). I specifically used:

fpath=($PWD/src/etc $fpath) autoload -Uz compinit && compinit -u

To setup the completions inside a zsh shell, but couldn't even get --jobs to show up.

`-m` is short for `--manifest-path`, and must be added in places where `--manifest-path` could be accepted.

weihanglo

I tested it. Working. Thanks!

View changes since this review

Update cargo submodule 26 commits in eb94155a9a60943bd7b1cb04abec42f5d0de6ddc..3bf1388b8823ec4eab622340036593381d8871aa 2026-04-09 13:10:20 +0000 to 2026-04-17 23:27:26 +0000 - Add global HTTP timeout tracking to http_async (rust-lang/cargo#16903) - feat(config): Stabilize `resolver.lockfile-path` config (rust-lang/cargo#16694) - chore(deps): update msrv (1 version) to v1.95 (rust-lang/cargo#16897) - fix: rebuild rustdoc json for different versions of a same crate (rust-lang/cargo#16773) - Add effective_url to http_async (rust-lang/cargo#16899) - Make crate downloads process as a queue rather than a stack (rust-lang/cargo#16898) - fix: sparse registry fetch progress reporting (rust-lang/cargo#16900) - chore: bump to 0.98.0; update changelog (rust-lang/cargo#16892) - docs(semver-check): update diagnostics to Rust 1.95 (rust-lang/cargo#16895) - docs(ref): Better highlight 'package --list' for include/exclude (rust-lang/cargo#16891) - docs: `include` doesnt apply gitignore from repo (rust-lang/cargo#16890) - fix: Update `bash` and `zsh` Autocompletion Documents to add `-m` (rust-lang/cargo#16888) - Add `-m` shorthand for `--manifest-path` (rust-lang/cargo#16858) - Fix a typo (rust-lang/cargo#16885) - Always take a shared lock on `.cargo-lock` (rust-lang/cargo#16886) - fix(toml): Teach users how to pin edition (rust-lang/cargo#16851) - fix: Prefer defined lint levels over default (rust-lang/cargo#16879) - chore(deps): bump rand from 0.10.0 to 0.10.1 (rust-lang/cargo#16883) - fix(lints): Ignore unused_crate_dependencies status (rust-lang/cargo#16877) - Copy cargo clean target-dir validation tests to clean_new_layout.rs (rust-lang/cargo#16878) - cargo clean: Add target directory validation (rust-lang/cargo#16712) - Docs: "api" in the configuration should not include a trailing slash (rust-lang/cargo#16869) - fix(core): use `closest_msg` to suggest similar member name for mistyped `-p` (rust-lang/cargo#16844) - chore(ci): Pin GitHub Actions to commit SHAs (rust-lang/cargo#16868) - chore(ci): Update `actions/checkout` from v5 to v6 (rust-lang/cargo#16867) - Add test for cargo install with github fastpath (rust-lang/cargo#16866) r? ghost

Update cargo submodule 28 commits in eb94155a9a60943bd7b1cb04abec42f5d0de6ddc..7ecf0285ebb408d596e4a8ac76a0980d8edb7005 2026-04-09 13:10:20 +0000 to 2026-04-18 15:34:11 +0000 - fix: use `portable-atomic` for 64-bit atomics (rust-lang/cargo#16906) - fix: rename incorrectly documented target-spec-json to json-target-sp… (rust-lang/cargo#16905) - Add global HTTP timeout tracking to http_async (rust-lang/cargo#16903) - feat(config): Stabilize `resolver.lockfile-path` config (rust-lang/cargo#16694) - chore(deps): update msrv (1 version) to v1.95 (rust-lang/cargo#16897) - fix: rebuild rustdoc json for different versions of a same crate (rust-lang/cargo#16773) - Add effective_url to http_async (rust-lang/cargo#16899) - Make crate downloads process as a queue rather than a stack (rust-lang/cargo#16898) - fix: sparse registry fetch progress reporting (rust-lang/cargo#16900) - chore: bump to 0.98.0; update changelog (rust-lang/cargo#16892) - docs(semver-check): update diagnostics to Rust 1.95 (rust-lang/cargo#16895) - docs(ref): Better highlight 'package --list' for include/exclude (rust-lang/cargo#16891) - docs: `include` doesnt apply gitignore from repo (rust-lang/cargo#16890) - fix: Update `bash` and `zsh` Autocompletion Documents to add `-m` (rust-lang/cargo#16888) - Add `-m` shorthand for `--manifest-path` (rust-lang/cargo#16858) - Fix a typo (rust-lang/cargo#16885) - Always take a shared lock on `.cargo-lock` (rust-lang/cargo#16886) - fix(toml): Teach users how to pin edition (rust-lang/cargo#16851) - fix: Prefer defined lint levels over default (rust-lang/cargo#16879) - chore(deps): bump rand from 0.10.0 to 0.10.1 (rust-lang/cargo#16883) - fix(lints): Ignore unused_crate_dependencies status (rust-lang/cargo#16877) - Copy cargo clean target-dir validation tests to clean_new_layout.rs (rust-lang/cargo#16878) - cargo clean: Add target directory validation (rust-lang/cargo#16712) - Docs: "api" in the configuration should not include a trailing slash (rust-lang/cargo#16869) - fix(core): use `closest_msg` to suggest similar member name for mistyped `-p` (rust-lang/cargo#16844) - chore(ci): Pin GitHub Actions to commit SHAs (rust-lang/cargo#16868) - chore(ci): Update `actions/checkout` from v5 to v6 (rust-lang/cargo#16867) - Add test for cargo install with github fastpath (rust-lang/cargo#16866)

rustbot added the A-completions Area: shell completions label Apr 15, 2026

bushrat011899 mentioned this pull request Apr 15, 2026

Add -m shorthand for --manifest-path #16858

Merged

bushrat011899 force-pushed the manifest_path_shorthand_shell_completion branch from 420b9ef to 330cfab Compare April 15, 2026 02:16

bushrat011899 marked this pull request as ready for review April 15, 2026 02:17

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2026

rustbot assigned epage Apr 15, 2026

rustbot assigned weihanglo and unassigned epage Apr 15, 2026

weihanglo reviewed Apr 15, 2026

View reviewed changes

fix: Update bash and zsh Autocompletion Documents to add -m

10dc107

`-m` is short for `--manifest-path`, and must be added in places where `--manifest-path` could be accepted.

bushrat011899 force-pushed the manifest_path_shorthand_shell_completion branch from 330cfab to 10dc107 Compare April 15, 2026 04:55

weihanglo approved these changes Apr 15, 2026

View reviewed changes

weihanglo added this pull request to the merge queue Apr 15, 2026

Merged via the queue into rust-lang:master with commit f4f977f Apr 15, 2026
29 checks passed

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2026

weihanglo mentioned this pull request Apr 18, 2026

Update cargo submodule rust-lang/rust#155470

Merged

rustbot added this to the 1.97.0 milestone Apr 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Update `bash` and `zsh` Autocompletion Documents to add `-m`#16888

fix: Update `bash` and `zsh` Autocompletion Documents to add `-m`#16888
weihanglo merged 1 commit intorust-lang:masterfrom
bushrat011899:manifest_path_shorthand_shell_completion

bushrat011899 commented Apr 15, 2026 •

edited

Loading

Uh oh!

rustbot commented Apr 15, 2026

Uh oh!

bushrat011899 commented Apr 15, 2026

Uh oh!

weihanglo Apr 15, 2026 •

edited by rustbot

Loading

Uh oh!

weihanglo Apr 15, 2026

Uh oh!

bushrat011899 Apr 15, 2026

Uh oh!

weihanglo left a comment •

edited by rustbot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

-    manifest='(-m --manifest-path)=[specify path to manifest]:path:_directories'
+    manifest=(
+        '(-m --manifest-path)'{-m+,--manifest-path=}'[specify path to manifest]:path:_directories'
+    )

Conversation

bushrat011899 commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR try to resolve?

How to test and review this PR?

Notes

Uh oh!

rustbot commented Apr 15, 2026

Uh oh!

bushrat011899 commented Apr 15, 2026

Uh oh!

weihanglo Apr 15, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weihanglo Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

bushrat011899 Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

weihanglo left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bushrat011899 commented Apr 15, 2026 •

edited

Loading

weihanglo Apr 15, 2026 •

edited by rustbot

Loading

weihanglo left a comment •

edited by rustbot

Loading