fix(tests): flaky test local_poll_adapter deferred_success#16909
Merged
weihanglo merged 1 commit intorust-lang:masterfrom Apr 19, 2026
Merged
fix(tests): flaky test local_poll_adapter deferred_success#16909weihanglo merged 1 commit intorust-lang:masterfrom
weihanglo merged 1 commit intorust-lang:masterfrom
Conversation
The deferred_success test used a timer to create a task future that would yield. Sometimes the timer was short enough that it had elapsed, so the task didn't yield in as the test expected. This change replaces the timer with a future that always yields exactly once.
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @epage rustbot has assigned @epage. Use Why was this reviewer chosen?The reviewer was selected based on:
|
weihanglo
approved these changes
Apr 19, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deferred_success test used a timer to create a task future that would yield. Sometimes the timer was short enough that it had elapsed by the time it was supposed to yield, so the task didn't yield as the test expected.
This change replaces the timer with a future that always yields exactly once.
Fixes #16907