Skip to content

Fix flaky test: proc_macro_in_artifact_dep#16922

Merged
weihanglo merged 1 commit intorust-lang:masterfrom
arlosi:flaky/proc-macro
Apr 21, 2026
Merged

Fix flaky test: proc_macro_in_artifact_dep#16922
weihanglo merged 1 commit intorust-lang:masterfrom
arlosi:flaky/proc-macro

Conversation

@arlosi
Copy link
Copy Markdown
Contributor

@arlosi arlosi commented Apr 21, 2026

Sometimes cargo will attempt to download pm before bin-uses-pm, which causes the expected error to occur before the [DOWNLOADED] message is printed.

Since the test doesn't care about downloading pm, we can exclude this case by matching ....

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 21, 2026

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ehuss, @epage, @weihanglo
  • @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
  • Random selection from ehuss, epage, weihanglo

@weihanglo weihanglo enabled auto-merge April 21, 2026 22:54
@weihanglo weihanglo added this pull request to the merge queue Apr 21, 2026
Merged via the queue into rust-lang:master with commit c4dabdc Apr 21, 2026
29 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2026
@arlosi arlosi deleted the flaky/proc-macro branch April 22, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants