docs(guide): Switch from third-party to first-party unused deps detection#16946
Merged
weihanglo merged 1 commit intorust-lang:masterfrom Apr 29, 2026
Merged
docs(guide): Switch from third-party to first-party unused deps detection#16946weihanglo merged 1 commit intorust-lang:masterfrom
weihanglo merged 1 commit intorust-lang:masterfrom
Conversation
…tion With rust-lang#16938 merged, the quality is high enough to generally recommend, even to dig through potential false positives.
rustbot
added
A-documenting-cargo-itself
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
weihanglo
reviewed
Apr 28, 2026
| Trade-offs: | ||
| - ✅ Faster full build and link times | ||
| - ❌ May incorrectly flag dependencies as unused or miss some | ||
| - ❌ **Requires using nightly Rust and an [unstable Cargo feature][cargo-lints] when reviewing unused dependencies** |
Member
There was a problem hiding this comment.
Not particular to this addition, though I wonder why we made nightly requirement bold.
Contributor
Author
There was a problem hiding this comment.
I think I did that and I think it was because nightly makes some of these questionable solutions for people (particularly when it requires using nightly for creating production code) that people should be immediately aware to decide if they want to do it.
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
weihanglo
approved these changes
Apr 29, 2026
rustbot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
May 2, 2026
Update cargo submodule 10 commits in eb9b60f1f6604b5e022c56be31692c215b8ba11d..4f9b52075316e9ced380c8fa492858048d5758b6 2026-04-24 20:52:07 +0000 to 2026-05-01 22:36:41 +0000 - chore(deps): update compatible (rust-lang/cargo#16952) - feat(lints): Add deny-by-default text_direction_codepoint lints (rust-lang/cargo#16950) - chore(deps): update embarkstudios/cargo-deny-action action to v2.0.17 (rust-lang/cargo#16953) - docs(guide): Switch from third-party to first-party unused deps detection (rust-lang/cargo#16946) - Remove curl dependency from crates-io crate (rust-lang/cargo#16936) - chore(deps): update gix to 0.83 (rust-lang/cargo#16945) - fix(compile): Where possible, hint about misplaced deps (rust-lang/cargo#16940) - Remove `windows-sys` from `home` (rust-lang/cargo#16918) - docs(resolver): `--precise <yanked>` is on stable (rust-lang/cargo#16944) - Update `gix` to 0.82 (with security fixes and hardened parsers) (rust-lang/cargo#16941)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
With #16938 merged, the quality is high enough to generally recommend, even to dig through potential false positives.
How to test and review this PR?