Skip to content

fix(diag): Track Cargo diagnostic warning/error count like is done for rustc#16981

Merged
weihanglo merged 5 commits into
rust-lang:masterfrom
epage:count
May 12, 2026
Merged

fix(diag): Track Cargo diagnostic warning/error count like is done for rustc#16981
weihanglo merged 5 commits into
rust-lang:masterfrom
epage:count

Conversation

@epage
Copy link
Copy Markdown
Contributor

@epage epage commented May 8, 2026

What does this PR try to resolve?

This is one of the steps towards stabilizing #12235.

This has the counts separate from the existing summaries because those are per-build-target while this is for the entire manifest.

This does not yet cover unused_dependencies.

How to test and review this PR?

This is also one of the steps for the plan laid out in #16975 as this will help us in unifying more of the existing diagnostics into this new diagnostic system.

@rustbot rustbot added A-workspaces Area: workspaces S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 8, 2026

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ehuss, @epage, @weihanglo
  • @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
  • Random selection from ehuss, weihanglo

Copy link
Copy Markdown
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the direction we head towards!

View changes since this review

@weihanglo weihanglo added this pull request to the merge queue May 12, 2026
Merged via the queue into rust-lang:master with commit 4b98db0 May 12, 2026
29 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-workspaces Area: workspaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants