Don't use the network for a publish dry-run test #17027
Merged
Merged
Conversation
This test does not need to be accessing the network. The test infrastructure has a way to simulate the existence of crates.io, so let's use that.
These were added to test the new behavior in rust-lang#16241.
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @epage rustbot has assigned @epage. Use Why was this reviewer chosen?The reviewer was selected based on:
|
epage
approved these changes
May 23, 2026
weihanglo
approved these changes
May 23, 2026
rustbot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
May 27, 2026
Update cargo submodule 13 commits in 4d1f984518c77fad6eeef4f40153b002a659e662..fbb61be30e5f9ac3a6ad58e56a5c0f5db2d2b3ef 2026-05-15 17:12:01 +0000 to 2026-05-26 15:08:03 +0000 - fix(compiler): forward verbose flag to rustc for local crates (rust-lang/cargo#17006) - Fix CVE-2026-5222 and CVE-2026-5223 (rust-lang/cargo#17031) - Don't use the network for a publish dry-run test (rust-lang/cargo#17027) - feat: Break out `RegistryConfig` and `crate_url` for interpreting `RegistryConfig::dl` (rust-lang/cargo#17011) - refactor(diag): Sort the PARSE_PASS_RULES (rust-lang/cargo#17019) - fix(artifact)!: Remove compat mode from artifacts (rust-lang/cargo#17016) - refactor(diag): Simplify adding of new diagnostics (rust-lang/cargo#17015) - test(package): Mark a network test that timed out on me (rust-lang/cargo#17017) - refactor(diag): Pull in the parse pass (rust-lang/cargo#17008) - test(lints): Avoid compiling where possible (rust-lang/cargo#17007) - fix(diag): Report deferred diagnostics like other diagnostics (rust-lang/cargo#16994) - refactor: drop `-Zunstable-options` for `rustdoc --emit` (rust-lang/cargo#17002) - chore(deps): update msrv (1 version) to v1.95 (rust-lang/cargo#17001)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test does not need to be accessing the network. The test infrastructure has a way to simulate the existence of crates.io, so let's use that.