Skip to content

Fix cargo test --doc not testing examples#2685

Merged
bors merged 5 commits into
rust-lang:masterfrom
mkroman:master
May 17, 2016
Merged

Fix cargo test --doc not testing examples#2685
bors merged 5 commits into
rust-lang:masterfrom
mkroman:master

Conversation

@mkroman
Copy link
Copy Markdown
Contributor

@mkroman mkroman commented May 13, 2016

When running cargo doc --test in a project folder, cargo does not test documentation examples, it only builds the project and exits.

Refer to issue #2684

@rust-highfive
Copy link
Copy Markdown

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wycats (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Copy Markdown
Member

Thanks! Could you be sure to add a test for this as well?

@mkroman
Copy link
Copy Markdown
Contributor Author

mkroman commented May 17, 2016

@alexcrichton I've updated your test to validate the output, but I've been unable to resolve the issue where a test fails when testing with Rust Beta on OS X.

Is it something wrong with my changes, or does test_cargo_doc::doc_multiple_deps just not clean up properly?

Edit:
The test seems to have been fixed.

@alexcrichton
Copy link
Copy Markdown
Member

@bors: r+ 3988946

Thanks!

@bors
Copy link
Copy Markdown
Contributor

bors commented May 17, 2016

⌛ Testing commit 3988946 with merge a394619...

bors added a commit that referenced this pull request May 17, 2016
Fix `cargo test --doc` not testing examples

When running cargo doc --test in a project folder, cargo does not test documentation examples, it only builds the project and exits.

Refer to issue #2684
@bors
Copy link
Copy Markdown
Contributor

bors commented May 17, 2016

💔 Test failed - cargo-win-gnu-32

@alexcrichton
Copy link
Copy Markdown
Member

@bors: retry

On Tue, May 17, 2016 at 10:00 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - cargo-win-gnu-32
http://buildbot.rust-lang.org/builders/cargo-win-gnu-32/builds/500


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#2685 (comment)

@bors
Copy link
Copy Markdown
Contributor

bors commented May 17, 2016

⚡ Previous build results for cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 are reusable. Rebuilding only cargo-win-gnu-32...

@bors
Copy link
Copy Markdown
Contributor

bors commented May 17, 2016

@bors bors merged commit 3988946 into rust-lang:master May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants