Skip to content

remove uses of Ord::clamp in scalbn #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgross35 merged 1 commit into from
Dec 17, 2025
Merged

remove uses of Ord::clamp in scalbn #1047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libm/src/math/generic/scalbn.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,14 @@ where
// Work aroudn this by using a different algorithm that calculates the prescale
// dynamically based on the maximum possible value. This adds more operations per round
// since it needs to construct the scale, but works better in the general case.
let add = -(n + sig_total_bits as i32).clamp(exp_min, sig_total_bits as i32);
let add = -(n + sig_total_bits as i32).max(exp_min);
let mul = F::from_parts(false, (F::EXP_BIAS as i32 - add) as u32, zero);

x *= mul;
n += add;

if n < exp_min {
let add = -(n + sig_total_bits as i32).clamp(exp_min, sig_total_bits as i32);
let add = -(n + sig_total_bits as i32).max(exp_min);
let mul = F::from_parts(false, (F::EXP_BIAS as i32 - add) as u32, zero);

x *= mul;
Expand Down
Loading