Error: SyntaxError: Failed to execute 'querySelector' on 'Document': '#user-content-are-we-stable-yet?' ...

[sentry]

Sentry Issue: CRATES-IO-FRONTEND-88

Error: SyntaxError: Failed to execute 'querySelector' on 'Document': '#user-content-are-we-stable-yet?' is not a valid selector.

SyntaxError: Failed to execute 'querySelector' on 'Document': '#user-content-are-we-stable-yet?' is not a valid selector.

can be reproduced on https://crates.io/crates/mdbook-latex#are-we-stable-yet%3F

[plaets]

(Posting for future reference)

Exception is thrown here (line 14 in the referenced commit, line 23 on prod as of 31.01.2021)

crates.io/app/initializers/hashchange.js

Line 14 in cbf8a6b

return document.querySelector(`#${name}`) || document.getElementsByName(name)[0];

Line 45 of mdbook-latex readme contains a link with a question mark, which causes the problem. It's the second "Are we stable yet?" link, the first link (from the table of contents) work fine as it does not contain a question mark.
I'm not sure what is the proper solution here, catch and ignore? Show a notification with something like "invalid link"?

[Turbo87]

https://github.com/schell/mogwai / https://crates.io/crates/mogwai has a similar issue. they include a linked table of contents in their README, which unfortunately includes broken links. in this case specifically the "beginning" link. if you click on it in the GitHub README then nothing happens because it can't find the related anchor ID, if you click on it on crates.io it fails with the above error. It looks like ? generally is not an allowed character in element IDs, so specifying it in the link is a mistake from the author, but it still doesn't mean that crates.io should fail like this. I think adding a try/catch block around the broken line and putting return; in the catch block should be sufficient to fix this unhandled error on Sentry..