-
Notifications
You must be signed in to change notification settings - Fork 676
Migrate crates_io_tarball to async/await
#10064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10064 +/- ##
==========================================
- Coverage 89.51% 89.49% -0.02%
==========================================
Files 295 295
Lines 31195 31233 +38
==========================================
+ Hits 27924 27953 +29
- Misses 3271 3280 +9 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Cargo.toml
Outdated
| typomania = { version = "=0.1.2", default-features = false } | ||
| url = "=2.5.4" | ||
| unicode-xid = "=0.2.6" | ||
| krata-tokio-tar = "=0.4.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is a fork and there is a reason for not using the original?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the original tokio-tar seems unmaintained, and I know it's used by uv and has been reviewed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's used by
uvand has been reviewed!
ah, perfect! that's roughly what I wanted to hear :D
a7597ea to
d4ce445
Compare
d4ce445 to
703f6a0
Compare
|
LGTM! nice work :) |
e763799 to
67b5de0
Compare
|
rebased this on top of #10068 to fix the |
This PR migrates crates_io_tarball to async/await, allowing us to remove the
spawn_blocking()call in the publish endpoint :)