Skip to content

Conversation

@eth3lbert
Copy link
Contributor

This PR migrates crates_io_tarball to async/await, allowing us to remove the spawn_blocking() call in the publish endpoint :)

@codecov
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 75.34247% with 18 lines in your changes missing coverage. Please review.

Project coverage is 89.49%. Comparing base (db4f944) to head (67b5de0).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...tes/crates_io_tarball/examples/check_all_crates.rs 0.00% 13 Missing ⚠️
crates/crates_io_tarball/examples/read_file.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10064      +/-   ##
==========================================
- Coverage   89.51%   89.49%   -0.02%     
==========================================
  Files         295      295              
  Lines       31195    31233      +38     
==========================================
+ Hits        27924    27953      +29     
- Misses       3271     3280       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 23, 2024
Cargo.toml Outdated
typomania = { version = "=0.1.2", default-features = false }
url = "=2.5.4"
unicode-xid = "=0.2.6"
krata-tokio-tar = "=0.4.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is a fork and there is a reason for not using the original?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the original tokio-tar seems unmaintained, and I know it's used by uv and has been reviewed!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's used by uv and has been reviewed!

ah, perfect! that's roughly what I wanted to hear :D

@eth3lbert eth3lbert force-pushed the async-tarball branch 2 times, most recently from a7597ea to d4ce445 Compare November 24, 2024 05:44
@Turbo87
Copy link
Member

Turbo87 commented Nov 25, 2024

LGTM! nice work :)

@Turbo87
Copy link
Member

Turbo87 commented Nov 25, 2024

rebased this on top of #10068 to fix the cargo-deny issue (i.e. rustls vulnerability)

@Turbo87 Turbo87 enabled auto-merge November 25, 2024 11:58
@Turbo87 Turbo87 merged commit e0afb0f into rust-lang:main Nov 25, 2024
8 checks passed
@eth3lbert eth3lbert deleted the async-tarball branch November 25, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants