Inline Maximums struct
#10096
Merged
Inline Maximums struct
#10096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A higher value isn't possible anyway due to the way the publish endpoint was designed...
This is only used in the publish endpoint, and can apparently be written quite a bit more concise... :D
Turbo87
added
C-internal 🔧
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10096 +/- ##
==========================================
- Coverage 89.48% 89.48% -0.01%
==========================================
Files 295 294 -1
Lines 31265 31256 -9
==========================================
- Hits 27977 27968 -9
Misses 3288 3288 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encoding this calculation in a
structdoes not seems to have much value since the calculation is only performed in the publish endpoint. Inlining the struct reduces unnecessary complexity and save a couple of lines :)