Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions app/components/crate-sidebar.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,15 @@
</span>
</time>

{{#if @version.msrv}}
{{#if @version.rust_version}}
<div local-class="msrv" data-test-msrv>
{{svg-jar "rust"}}
<span>
v{{@version.msrv}}

<EmberTooltip>
&quot;Minimum Supported Rust Version&quot;
{{#if @version.edition}}
<div local-class="edition">requires Rust Edition {{@version.edition}}</div>
{{/if}}
</EmberTooltip>
</span>
<Msrv @version={{@version}} />
</div>
{{else if @version.edition}}
<div local-class="edition" data-test-edition>
{{svg-jar "rust"}}
<Edition @version={{@version}} />
</div>
{{/if}}

Expand Down
8 changes: 3 additions & 5 deletions app/components/crate-sidebar.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

.date,
.msrv,
.edition,
.license,
.bytes {
display: flex;
Expand All @@ -34,16 +35,13 @@
}

.date,
.msrv {
.msrv,
.edition {
[title], :global(.ember-tooltip-target) {
cursor: help;
}
}

.edition {
margin-top: var(--space-2xs);
}

.license {
a {
color: var(--main-color);
Expand Down
14 changes: 14 additions & 0 deletions app/components/edition.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<span>
{{@version.edition}} edition

<EmberTooltip>
This crate version does not declare a Minimum Supported Rust Version, but
does require the {{@version.edition}} Rust Edition.

<div local-class="edition-msrv">
{{@version.editionMsrv}} was the first version of Rust in this edition,
but this crate may require features that were added in later versions of
Rust.
</div>
</EmberTooltip>
</span>
3 changes: 3 additions & 0 deletions app/components/edition.module.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.edition-msrv {
margin-top: var(--space-2xs);
}
10 changes: 10 additions & 0 deletions app/components/msrv.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<span>
v{{@version.msrv}}

<EmberTooltip>
&quot;Minimum Supported Rust Version&quot;
{{#if @version.edition}}
<div local-class="edition">requires Rust Edition {{@version.edition}}</div>
{{/if}}
</EmberTooltip>
</span>
3 changes: 3 additions & 0 deletions app/components/msrv.module.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.edition {
margin-top: var(--space-2xs);
}
16 changes: 7 additions & 9 deletions app/components/version-list/row.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -67,17 +67,15 @@

{{#if (or @version.crate_size @version.license @version.featureList)}}
<div local-class="metadata-row">
{{#if @version.msrv}}
{{#if @version.rust_version}}
<span local-class="msrv">
{{svg-jar "rust"}}
v{{@version.msrv}}

<EmberTooltip>
&quot;Minimum Supported Rust Version&quot;
{{#if @version.edition}}
<div local-class="edition">requires Rust Edition {{@version.edition}}</div>
{{/if}}
</EmberTooltip>
<Msrv @version={{@version}} />
</span>
{{else if @version.edition}}
<span local-class="edition">
{{svg-jar "rust"}}
<Edition @version={{@version}} />
</span>
{{/if}}

Expand Down
6 changes: 2 additions & 4 deletions app/components/version-list/row.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -205,17 +205,15 @@

.msrv {
text-transform: initial;
}

.msrv, .edition {
svg {
/* this makes the text look a little more aligned with the icon... 🤷 */
margin-bottom: -0.15em;
}
}

.edition {
margin-top: var(--space-2xs);
}

.bytes {
font-variant-numeric: tabular-nums;
text-transform: none;
Expand Down
16 changes: 10 additions & 6 deletions app/models/version.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,8 @@ export default class Version extends Model {
return this.belongsTo('crate').id();
}

get msrv() {
let rustVersion = this.rust_version;
if (rustVersion) {
// add `.0` suffix if the `rust-version` field only has two version components
return /^[^.]+\.[^.]+$/.test(rustVersion) ? `${rustVersion}.0` : rustVersion;
} else if (this.edition === '2018') {
get editionMsrv() {
if (this.edition === '2018') {
return '1.31.0';
} else if (this.edition === '2021') {
return '1.56.0';
Expand All @@ -64,6 +60,14 @@ export default class Version extends Model {
}
}

get msrv() {
let rustVersion = this.rust_version;
if (rustVersion) {
// add `.0` suffix if the `rust-version` field only has two version components
return /^[^.]+\.[^.]+$/.test(rustVersion) ? `${rustVersion}.0` : rustVersion;
}
}

get isNew() {
return Date.now() - this.created_at.getTime() < EIGHT_DAYS;
}
Expand Down
20 changes: 20 additions & 0 deletions tests/models/version-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,26 @@ module('Model | Version', function (hooks) {
assert.false(versions[0].isNew);
});

test('editionMsrv', async function (assert) {
let version = await this.store.createRecord('version');
assert.strictEqual(version.editionMsrv, undefined);

version.edition = '2015';
assert.strictEqual(version.editionMsrv, undefined);

version.edition = '2018';
assert.strictEqual(version.editionMsrv, '1.31.0');

version.edition = '2021';
assert.strictEqual(version.editionMsrv, '1.56.0');

version.edition = '2024';
assert.strictEqual(version.editionMsrv, '1.85.0');

version.edition = '2027';
assert.strictEqual(version.editionMsrv, undefined);
});

test('msrv', async function (assert) {
let version = await this.store.createRecord('version');
assert.strictEqual(version.msrv, undefined);
Expand Down
Loading