trustpub: Add cursor-based pagination to GitHub configs list endpoint #12236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cursor-based pagination to the `/api/v1/trusted_publishing/github_configs` endpoint using the `id` field as the cursor. Pagination is always enabled with a default of 10 items per page (following the codebase standard). Key changes: - Add `ListResponseMeta` with `total` and `next_page` fields - Implement seek-based pagination ordered by `id` ascending - Support `?per_page=N` (max 100) and `?seek=<encoded>` query parameters - Optimize to avoid COUNT query when first page fits all results - Add comprehensive pagination test covering multiple pages The implementation follows existing pagination patterns from the versions endpoint, using the `seek!()` macro for type-safe cursor serialization.
Turbo87
force-pushed
the
trustpub-list-pagination
branch
from
f8607ae to
850e434
Compare
eth3lbert
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cursor-based pagination to the
/api/v1/trusted_publishing/github_configsendpoint using theidfield as the cursor. Pagination is always enabled with a default of 10 items per page (following the codebase standard).The implementation follows existing pagination patterns from the versions endpoint, using the
seek!()macro for type-safe cursor serialization.