worker: add more fine-grained logging for Git index syncs #12282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be reverted once we have the data we need, but in the short term, this will be useful to decide our next step with rust-lang#12281.
LawnGnome
added
C-internal 🔧
Turbo87
approved these changes
Nov 6, 2025
Member
Turbo87
left a comment
Turbo87
left a comment
There was a problem hiding this comment.
Thanks!
This PR triggered me to look at Sentry, because I noticed that run_via_cli() was already using #[instrument] and so I expected the traces to be visible on Sentry. Unfortunately we had a bug in how we handle the spans and Sentry hubs, so only the root transaction was ultimately visible.
#12284 fixes that issue.
Once that PR is merged we should see all the tracing spans on Sentry for the background jobs. I'm not opposed to still merging this PR, but let me know what you think :)
Contributor
Author
Member
|
Looks like we're running into rate limits with Sentry, so we may as well merge this and rely on Datadog instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be reverted once we have the data we need, but in the short term, this will be useful to decide our next step with #12281.
The total extra cost here is four log lines per crate version publish, which I think we can comfortably incur for now.