svelte: Import base layout and migrate Header component
#12502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
eth3lbert
approved these changes
Dec 15, 2025
Contributor
eth3lbert
left a comment
eth3lbert
left a comment
There was a problem hiding this comment.
Awesome! The simplicity and the fact that we can just reuse a lot of our original codebase are exactly what I had hoped for, making this migration much easier (especially compared to other options)! :D
Contributor
|
Also, feel free to hand off parts of the migration to me if needed! :D |
Member
Author
thanks for the offer! my goal is to get the basics right first and once we move on to migrating the individual routes it will be easier to spread the work. I really appreciate your fast reviews though! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR imports the global CSS styles from the Ember.js app into the Svelte app. It also migrates the
application.gjs/cssfiles to the Svelteroutes/+layout.sveltefile, and theHeadercomponent. Both contain plenty ofTODOcomments for the parts that are not implemented yet, so that we don't forget to implement them before we make this our primary frontend application.Related