Use .tool-versions file to pin Node.js and pnpm versions
#12538
Merged
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
the
C-internal 🔧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.tool-versionsfile is a conventional format from theasdftool (see https://asdf-vm.com/guide/getting-started.html#_6-set-a-version) and is essentially a simple<tool> <version>mapping.Turbo87/heroku-buildpack-crates-io@76b621d adjusts our buildpack to read the Node.js and pnpm versions from that files instead of
pnpm, which also means that we no longer need to installjqsincegrep+awkis sufficient. Note that the parser is very basic at the moment and currently does not support trailing comments after the version string.As for the "why": it has been fairly annoying to locally always have to update the Node.js and pnpm versions to match what crates.io has pinned. This PR also relaxes the
enginesdeclarations, so that now only the major version needs to match for local development, while the deployment process and CI are using the pinned versions.