svelte: Improve $props() usage
#12549
Merged
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth3lbert
approved these changes
Dec 18, 2025
Contributor
eth3lbert
left a comment
eth3lbert
left a comment
There was a problem hiding this comment.
Just a small nit regarding the class attribute. :D
Turbo87
force-pushed
the
svelte-props
branch
from
0f66a80 to
8a29df4
Compare
Co-authored-by: eth3lbert <eth3lbert+dev@gmail.com>
Turbo87
force-pushed
the
svelte-props
branch
from
8a29df4 to
bdba5d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
[key: string]: unknown;in thePropsinterfaces withHTMLAttributes<HTMLDivElement>. That allows us to get proper auto-completion for the regular HTML element props.This PR also ensures that the
classattributes of the components are merged correctly when passed in from the outside.Related