Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 15, 2022

Using add_custom_metadata() in the email code makes it hard to port the log_request middleware to axum, due to the CUSTOM_METADATA thread local which appears to be hard to migrate into the async world. The easiest solution for now is to use tracing calls directly instead and log the messages outside of the regular HTTP traffic logs.

Related:

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Dec 15, 2022
@Turbo87 Turbo87 merged commit c73677e into rust-lang:master Dec 15, 2022
@Turbo87 Turbo87 deleted the email-tracing branch December 15, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant