Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Sep 26, 2024

This makes it easier to see at a glance which crate a log message belongs to. tracing fields are useful too, but in this case it makes more sense to have the name directly in the log message.

This makes it easier to see at a glance which crate a log message belongs to. tracing fields are useful too, but in this case it makes more sense to have the name directly in the log message.
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Sep 26, 2024
@codecov
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 89.09%. Comparing base (6d1789d) to head (f2d76da).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/admin/delete_crate.rs 0.00% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9519   +/-   ##
=======================================
  Coverage   89.09%   89.09%           
=======================================
  Files         286      286           
  Lines       28878    28878           
=======================================
+ Hits        25728    25729    +1     
+ Misses       3150     3149    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit 1e66a57 into rust-lang:main Sep 26, 2024
10 checks passed
@Turbo87 Turbo87 deleted the delete-logging branch September 26, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant