Remove CI system detection #9643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9643 +/- ##
==========================================
+ Coverage 88.68% 88.71% +0.02%
==========================================
Files 288 287 -1
Lines 29369 29336 -33
==========================================
- Hits 26047 26026 -21
+ Misses 3322 3310 -12 ☔ View full report in Codecov by Sentry. |
This was interesting when we were still routing the download traffic through our API servers, but this is no longer the case, so there is very little point in still running this detection for each request.
|
looks like there are no objections, so I'll go ahead and merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was interesting when we were still routing the download traffic through our API servers, but this is no longer the case, so there is very little point in still running this detection for each request.