Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 13, 2024

Unfortunately we can't completely avoid it yet, since our email sending code is still synchronous, but we'll get there eventually...

(best reviewed with "hide whitespace changes" 😉)

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Oct 13, 2024
@codecov
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 97.56098% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.69%. Comparing base (59303c8) to head (26b14b1).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/worker/jobs/sync_admins.rs 97.56% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9654      +/-   ##
==========================================
- Coverage   88.69%   88.69%   -0.01%     
==========================================
  Files         288      288              
  Lines       29371    29374       +3     
==========================================
+ Hits        26052    26054       +2     
- Misses       3319     3320       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit 813f349 into rust-lang:main Oct 13, 2024
10 checks passed
@Turbo87 Turbo87 deleted the a-sync-admins branch October 13, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant