typosquat/test_util: Simplify Faker
#9665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `create_or_update()` is called with a `None` argument then no emails will be saved and sent, which means that the `Emails` instance isn't actually being used and created for nothing. Additionally, we don't need the "upsert" behavior since our test database shouldn't start with any content anyway. In other words: we can just `INSERT` the `NewUser` instance directly and remove the `email` field from the `Faker` struct.
Since the `Faker` struct has no fields anymore, we may as well convert these to regular functions that don't need an instance of the struct.
Turbo87
added
C-internal 🔧
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9665 +/- ##
==========================================
- Coverage 88.68% 88.68% -0.01%
==========================================
Files 288 288
Lines 29369 29353 -16
==========================================
- Hits 26047 26032 -15
+ Misses 3322 3321 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aren't actually using the
Emailsinstance in this test suite, so we may as well remove it and simplify theFakerstruct to be a module with regular functions instead :)/cc @LawnGnome