Skip to content

Conversation

@eth3lbert
Copy link
Contributor

This PR focuses on converting the check() and related implementations to async, so there might be spawn_blocking() fns in controllers that can be removed. However, I expect these changes to be made in a separate PR :)

@codecov
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 97.63780% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.88%. Comparing base (e35a4f5) to head (5fcdaf4).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/controllers/user/update.rs 50.00% 2 Missing ⚠️
src/auth.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9872      +/-   ##
==========================================
+ Coverage   88.85%   88.88%   +0.02%     
==========================================
  Files         289      289              
  Lines       30002    30080      +78     
==========================================
+ Hits        26659    26737      +78     
  Misses       3343     3343              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! 👍

@Turbo87 Turbo87 merged commit a2baad2 into rust-lang:main Nov 8, 2024
10 checks passed
@eth3lbert eth3lbert deleted the async-auth branch November 8, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants