-
Notifications
You must be signed in to change notification settings - Fork 677
auth: Convert check() and related blocking fns to async
#9872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We don't use blocking check implementations anymore, so we remove these temporary prefixes.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9872 +/- ##
==========================================
+ Coverage 88.85% 88.88% +0.02%
==========================================
Files 289 289
Lines 30002 30080 +78
==========================================
+ Hits 26659 26737 +78
Misses 3343 3343 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! 👍
This PR focuses on converting the
check()and related implementations to async, so there might bespawn_blocking()fns in controllers that can be removed. However, I expect these changes to be made in a separate PR :)