Revert "admin/render_readmes: Remove redundant tokio runtime" #9889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dda300e. The relevant code was used inside a `std::thread::spawn()` block, which currently does not have an attached tokio runtime, which means that `Handle::current()` panics in this case. Reverting the commit fixes the issue for now, but this should probably be refactored to use tokio tasks anyway...
Turbo87
force-pushed
the
revert-runtime
branch
from
b8f134b to
754dfa1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9889 +/- ##
==========================================
- Coverage 89.00% 88.99% -0.02%
==========================================
Files 290 290
Lines 30080 30083 +3
==========================================
- Hits 26773 26772 -1
- Misses 3307 3311 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit dda300e.
The relevant code was used inside a
std::thread::spawn()block, which currently does not have an attached tokio runtime, which means thatHandle::current()panics in this case. Reverting the commit fixes the issue for now, but this should probably be refactored to use tokio tasks anyway...