database: Change versions.crate_size to be NOT NULL
#9926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9926 +/- ##
==========================================
- Coverage 89.09% 89.08% -0.01%
==========================================
Files 290 290
Lines 30086 30093 +7
==========================================
+ Hits 26804 26808 +4
- Misses 3282 3285 +3 ☔ View full report in Codecov by Sentry. |
Turbo87
force-pushed
the
not-null-size
branch
from
62d52eb to
60e926f
Compare
eth3lbert
approved these changes
Nov 15, 2024
Contributor
eth3lbert
left a comment
eth3lbert
left a comment
There was a problem hiding this comment.
Since the backfill process has been completed, I believe this shouldn't cause any issues. For local env, IIUC, running import-database-dump.sh should include the backfilled values. Otherwise, users might need to perform their own backfill process.
jNullj
added a commit
to jNullj/shields-fun-fork
that referenced
this pull request
Nov 21, 2024
changes upstream removed all null crate_size see also rust-lang/crates.io#9926
github-merge-queue bot
pushed a commit
to badges/shields
that referenced
this pull request
Nov 26, 2024
* remove obsolete test for version without size changes upstream removed all null crate_size see also rust-lang/crates.io#9926 * remove null handling in CratesSize service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on Zulip, the
versions.crate_sizecolumn in our database has been backfilled and does not contain anyNULLvalues anymore.This PR adjusts the column to be
NOT NULLto avoid these values from being reintroduced in the future :)Related: