boot/categories: Migrate sync_with_connection() to diesel-async queries
#9936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9936 +/- ##
==========================================
- Coverage 89.09% 89.09% -0.01%
==========================================
Files 290 290
Lines 30054 30072 +18
==========================================
+ Hits 26777 26793 +16
- Misses 3277 3279 +2 ☔ View full report in Codecov by Sentry. |
eth3lbert
approved these changes
Nov 14, 2024
Turbo87
force-pushed
the
async-categories
branch
from
3813d3e to
db2f11c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to move more code out of
spawn_blocking()blocks :)