typosquat: Asyncify all the things #9937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9937 +/- ##
==========================================
- Coverage 89.23% 89.22% -0.01%
==========================================
Files 292 292
Lines 30409 30434 +25
==========================================
+ Hits 27135 27156 +21
- Misses 3274 3278 +4 ☔ View full report in Codecov by Sentry. |
Turbo87
force-pushed
the
async-typosquat
branch
from
4c167c5 to
e617cd0
Compare
|
☔ The latest upstream changes (presumably #9961) made this pull request unmergeable. Please resolve the merge conflicts. |
Turbo87
force-pushed
the
async-typosquat
branch
2 times, most recently
from
55e401e to
10234d5
Compare
|
☔ The latest upstream changes (presumably #9973) made this pull request unmergeable. Please resolve the merge conflicts. |
Turbo87
force-pushed
the
async-typosquat
branch
from
10234d5 to
221e97f
Compare
Turbo87
force-pushed
the
async-typosquat
branch
from
221e97f to
4f0e106
Compare
LawnGnome
approved these changes
Nov 18, 2024
Comment on lines
+46
to
+65
| let crates = models::Crate::all() | ||
| .inner_join(crate_downloads::table) | ||
| .order(crate_downloads::downloads.desc()) | ||
| .limit(num) | ||
| .load_iter::<models::Crate, DefaultLoadingMode>(conn)? | ||
| { | ||
| let krate = result?; | ||
| crates.insert( | ||
| krate.id, | ||
| ( | ||
| krate.name, | ||
| Crate { | ||
| owners: HashSet::new(), | ||
| }, | ||
| ), | ||
| ); | ||
| } | ||
| .load_stream::<models::Crate>(conn) | ||
| .await? | ||
| .try_fold(crates, |mut crates, krate| { | ||
| crates.insert( | ||
| krate.id, | ||
| ( | ||
| krate.name, | ||
| Crate { | ||
| owners: HashSet::new(), | ||
| }, | ||
| ), | ||
| ); | ||
|
|
||
| futures_util::future::ready(Ok(crates)) | ||
| }) | ||
| .await?; |
There was a problem hiding this comment.
This is just straight up better, async or no. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to get rid of these pesky sync database connections.
I wish it would've been possible to split this into multiple commits, but... no 😅