Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 17, 2024

Now that we are more and more using async connections, the test_db_connection() fn isn't all that useful anymore since it always returns a sync connection. We can call these two statements individually instead to make our tests easier to migrate to async connections.

Now that we are more and more using async connections, the `test_db_connection()` fn isn't all that useful anymore since it always returns a sync connection. We can call these two statements individually instead to make our tests easier to migrate to async connections.
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 17, 2024
@Turbo87 Turbo87 enabled auto-merge (squash) November 17, 2024 09:53
@Turbo87 Turbo87 merged commit 56e4a55 into rust-lang:main Nov 17, 2024
8 checks passed
@Turbo87 Turbo87 deleted the test-conn branch November 17, 2024 10:00
@codecov
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.23%. Comparing base (732b81f) to head (31d72d6).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9976      +/-   ##
==========================================
+ Coverage   89.22%   89.23%   +0.01%     
==========================================
  Files         293      292       -1     
  Lines       30394    30409      +15     
==========================================
+ Hits        27118    27135      +17     
+ Misses       3276     3274       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant