Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 17, 2024

gh_id = 0 has a special meaning within our database. Depending on the order of the tests we could sometimes see tests failing because the initial user was created with gh_id = 0. This commit fixes the flakiness by starting the gh_id values at 1 instead.

and yes, I thought I was going insane... 🙈

`gh_id = 0` has a special meaning within our database. Depending on the order of the tests we could sometimes see tests failing because the initial user was created with `gh_id = 0`. This commit fixes the flakiness by starting the `gh_id` values at 1 instead.
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 17, 2024
@Turbo87 Turbo87 enabled auto-merge (squash) November 17, 2024 22:52
@Turbo87 Turbo87 merged commit c232a08 into rust-lang:main Nov 17, 2024
8 checks passed
@Turbo87 Turbo87 deleted the gh-id-flakyness branch November 17, 2024 23:02
@codecov
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.23%. Comparing base (d3d908d) to head (b79f592).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9980   +/-   ##
=======================================
  Coverage   89.23%   89.23%           
=======================================
  Files         292      292           
  Lines       30409    30409           
=======================================
  Hits        27134    27134           
  Misses       3275     3275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant