Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 18, 2024

The creation of users and tokens is currently hard to convert to diesel-async because the test suite is using sync fn calls to create them. This PR migrates the fns to async/await, even if internally some of them are not actually using async/await yet. This makes it much easier to port these to diesel-async in follow-up pull requests.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 18, 2024
@codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 99.66443% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.14%. Comparing base (1032ce9) to head (8327b3d).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/tests/util/test_app.rs 92.85% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9987      +/-   ##
==========================================
- Coverage   89.20%   89.14%   -0.07%     
==========================================
  Files         292      294       +2     
  Lines       30412    30590     +178     
==========================================
+ Hits        27130    27269     +139     
- Misses       3282     3321      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit 57e3bb4 into rust-lang:main Nov 18, 2024
10 checks passed
@Turbo87 Turbo87 deleted the async-test-app branch November 18, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant