Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 18, 2024

Having two i32 arguments in the new() fn was a bit dangerous and could easily lead to someone unintentionally swapping the values. This commit changes the NewTeam construction to use the builder pattern with named fns instead to avoid the potential confusion.

Having two `i32` arguments in the `new()` fn was a bit dangerous and could easily lead to someone unintentionally swapping the values. This commit changes the `NewTeam` construction to use the builder pattern with named fns instead to avoid the potential confusion.
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 18, 2024
@codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (d8888c6) to head (4317a49).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9990      +/-   ##
==========================================
- Coverage   89.13%   89.13%   -0.01%     
==========================================
  Files         294      294              
  Lines       30605    30593      -12     
==========================================
- Hits        27279    27268      -11     
+ Misses       3326     3325       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit db62001 into rust-lang:main Nov 18, 2024
10 checks passed
@Turbo87 Turbo87 deleted the team-building branch November 18, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant